kotlin-toolkit icon indicating copy to clipboard operation
kotlin-toolkit copied to clipboard

Epub Highlight text empty space.

Open DominikKu opened this issue 2 years ago • 3 comments

Bug Report

What happened?

When select more than few lines and mark it as highlight, note or underline, in the result selected area change to annotation correctly but have spaces beetwen text.

highlight highlightselected

How to reproduce?

1.Open epub 2.Select more than few lines. 3.Mark as highlight, note or underline.

Environment

Android : 11 Device : One Plus 6 Readium version: develop branch - 20.01.2023, commit af2f764020c252d5ccf69e94e4956e4c7769520a

DominikKu avatar Feb 07 '23 08:02 DominikKu

There's a heuristic that merges highlight boxes together when they are close by. It might need to be adjusted although it depends from books to books.

https://github.com/readium/kotlin-toolkit/blob/830812b02a0597b4b22d0d37ec35846db24cb0a4/readium/navigator/src/main/assets/_scripts/src/decorator.js#L233-L237

Could you share this book you used as an example?

Note that this is not high priority, so it probably won't be fixed (by the core maintainers) soon.

mickael-menu avatar Feb 07 '23 11:02 mickael-menu

This is the one of books when i could reproduce this situtaion but like you said it probably depends from books to books because it is reproducable only on few books. https://drive.google.com/file/d/1qHhUGbRRY4IGsai64z8kVnbdAruWVKks/view?usp=sharing

DominikKu avatar Feb 07 '23 12:02 DominikKu