kotlin-toolkit icon indicating copy to clipboard operation
kotlin-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon readium

Upgrade gradle

Open armendh opened this issue 3 years ago • 3 comments

armendh avatar Jul 10 '22 19:07 armendh

Hi @armendh, this looks better now. As I mentioned in an earlier comment, this most likely would be merged right before or right after a Readium release. Just a few things:

  1. In pdfium-document, pdfium-navigator, pspdfkit-document, and pspdfkit-navigator: Can you update coroutines-android and coroutines-core to 1.6.3 and fragment-ktx to 1.5.0? Or if you already did that and ran into an issue, disregard.
  2. In MediaNavigator, can you change that setContentType to C.AUDIO_CONTENT_TYPE_MUSIC?

stevenzeck avatar Jul 11 '22 01:07 stevenzeck

Hi @armendh, this looks better now. As I mentioned in an earlier comment, this most likely would be merged right before or right after a Readium release. Just a few things:

  1. In pdfium-document, pdfium-navigator, pspdfkit-document, and pspdfkit-navigator: Can you update coroutines-android and coroutines-core to 1.6.3 and fragment-ktx to 1.5.0? Or if you already did that and ran into an issue, disregard.
  2. In MediaNavigator, can you change that setContentType to C.AUDIO_CONTENT_TYPE_MUSIC?

updated

armendh avatar Jul 11 '22 10:07 armendh

@armendh Sorry, can you make that same change in ExoMediaPlayer? C.AUDIO_CONTENT_TYPE_MUSIC

stevenzeck avatar Jul 12 '22 02:07 stevenzeck

@qnga Finalized this PR in https://github.com/readium/kotlin-toolkit/pull/282. Thanks @armendh for kickstarting it.

mickael-menu avatar Oct 04 '22 17:10 mickael-menu