reactwg
[0.75] Implement more missing methods on WithRuntimeDecorator
Target Branch(es)
0.75
Link to commit or PR to be picked
https://github.com/facebook/react-native/commit/993f9fd8db5fe4df495b3a3454273b0e11fef489
Description
This Implement more missing methods on WithRuntimeDecorator is a followup pick to the already selected cherrypick in 0.75 Add missing WithRuntimeDecorator methods and should probably be added for completeness According to the author of the commit these missing methods unfortunately threw no compile time errors due to inheritance.
This will most likely require a similar pick on the hermes side, so it's not a trivial one.
As the two commits were less than a day apart, and is only an implementation of the missing api, theoretically speaking there shouldn't actually be a problem. But we can always wait till 0.76 beta is released and the commit is tested and found stable, no particular hurry on this one.
As the two commits were less than a day apart
Which two commits are you referring to?
I am referring to these two commits only. The first of the commits is already merged in this [0.75] branch.
I am referring to these two commits only. The first of the commits is already merged in this [0.75] branch.
Correct, and we had to bump hermes for that specific commit.
We'll have to do the same for this other commit if we decide to include it
Noted above.
Adding the corresponding hermes commit-ish for the should bump hermes (?) check if you do decide to cherry-pick.
Examining the compare of two consecutive hermes commit tags hermes engine RN-0.75.1 vs 0.76.0, it may be possible the previous bump to Hermes might not have actually happened either. Is there any way to query which hermes engine is actually running?
