react-play icon indicating copy to clipboard operation
react-play copied to clipboard

add: calculator play

Open yashpaddalwar1234 opened this issue 3 years ago • 7 comments

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

This is a calculator app play which would be able to perform basic arithmetic operations

Fixes #727

Type of change

Please delete options that are not relevant.

  • [ ] New Play (non-breaking change which adds functionality)

How Has This Been Tested?

e2e and local testing Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

yashpaddalwar1234 avatar Oct 19 '22 01:10 yashpaddalwar1234

Someone is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Oct 19 '22 01:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 20, 2022 at 3:26PM (UTC)

vercel[bot] avatar Oct 19 '22 02:10 vercel[bot]

this is most likely a javascript play not react play.

Angryman18 avatar Oct 19 '22 03:10 Angryman18

this is most likely a javascript play not react play.

Can you explain a bit more?. Because this play uses JSX and hooks.

harshsinghatz avatar Oct 19 '22 05:10 harshsinghatz

this is most likely a javascript play not react play.

Can you explain a bit more?. Because this play uses JSX and hooks.

no its fine. its good. but i see calling document object and modifying realdom at several places.

Angryman18 avatar Oct 19 '22 15:10 Angryman18

this is most likely a javascript play not react play.

Can you explain a bit more?. Because this play uses JSX and hooks.

no its fine. its good. but i see calling document object and modifying realdom at several places.

Got it @Angryman18 !, but I guess this should work as well

harshsinghatz avatar Oct 19 '22 16:10 harshsinghatz

@Angryman18 are you good with this PR?

koustov avatar Oct 20 '22 08:10 koustov

any update @harshsinghatz

Angryman18 avatar Nov 13 '22 01:11 Angryman18

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Dec 13 '22 12:12 github-actions[bot]