react-play icon indicating copy to clipboard operation
react-play copied to clipboard

create: todo list play

Open saurav-19 opened this issue 3 years ago • 3 comments

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

  • This is the PR for the play "Todo list"
  • Fixes #708

Type of change

  • Add the play "To do list"

Please delete options that are not relevant.

  • [ ] New Play (non-breaking change which adds functionality)

How Has This Been Tested?

e2e and tested across all viewports

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

saurav-19 avatar Oct 16 '22 11:10 saurav-19

Someone is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Oct 16 '22 11:10 vercel[bot]

Fixes #708

koustov avatar Oct 19 '22 18:10 koustov

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 29, 2022 at 6:56AM (UTC)

vercel[bot] avatar Oct 19 '22 18:10 vercel[bot]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Nov 28 '22 12:11 github-actions[bot]

@saurav-19

Few comments

  • Change the input from a textarea to a regular input and make the input a bit longer. That way you don't have to worry about vertical spacing. Changing to an input would also allow the user to press the Enter key to add an item
  • And a small style issue was that the Todo item/card does not resize/fit the content if the input is longer than it. A solution for this would be to either style the item/card to change to fit the content or set a maximum character limit to the input

Everything else looks great!

Hey @saurav-19 This is very close to get done. Could you please take care of the comments?

atapas avatar Dec 02 '22 04:12 atapas

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Jan 02 '23 12:01 github-actions[bot]