react-play icon indicating copy to clipboard operation
react-play copied to clipboard

[Fix #705]: Search plays on typing text instead of hitting enter all the time

Open siddxharth opened this issue 3 years ago • 2 comments

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Now, the search plays each time there is a change to the search field. No need to press enter to search now.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #705

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested it myself on my localhost. All tests pass.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [x] New and existing unit tests pass locally with my changes

siddxharth avatar Oct 16 '22 07:10 siddxharth

@siddxharth is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Oct 16 '22 07:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 6:27PM (UTC)

vercel[bot] avatar Oct 17 '22 16:10 vercel[bot]

@siddxharth have you incorporated the comments?

koustov avatar Nov 02 '22 15:11 koustov

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Dec 03 '22 12:12 github-actions[bot]