react-play icon indicating copy to clipboard operation
react-play copied to clipboard

alt for play cover images

Open JosephSchec opened this issue 3 years ago • 3 comments

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (697)

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

I removed src url for images and the correct alt showed up.

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] My changes generate no new warnings

JosephSchec avatar Oct 14 '22 17:10 JosephSchec

@jSchechter1 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Oct 14 '22 17:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 29, 2022 at 7:15AM (UTC)

vercel[bot] avatar Oct 14 '22 17:10 vercel[bot]

@JosephSchec @bhtibrewal The linked issue is already closed. Was it done unintentionally? If so please re-open in order to start the review process

koustov avatar Oct 19 '22 18:10 koustov

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Nov 28 '22 12:11 github-actions[bot]