react-play icon indicating copy to clipboard operation
react-play copied to clipboard

🐛 [Bug report]: Filters - Clear all doesnt take the user back to the original state

Open NagarjunShroff opened this issue 2 years ago • 2 comments

Descrcibe the bug?

After apply all the filters, clearing them all and re-apply doesn't take the user back to the original state( it doesn't render the complete list of plays)

Steps to reproduce the bug?

  1. Add all the filters Level, Tags, Creator, and Language.
  2. Click on apply to see the results.
  3. Click on the filter icon and clear all filters and apply.

Another issue: Onclick of filter icon modal rerenders.

Expected behavior

On clearing all the filters, should render a complete list of play available in the system.

Desktop (Please provide your system information)

Browser: Chrome

Mobile (Please provide your device information)

No response

Screenshot / Screenshare

ReactPlay - Plays

Relevant log output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

NagarjunShroff avatar Oct 14 '22 07:10 NagarjunShroff

the issue is already there #472 i guess @supminn is working on it

Angryman18 avatar Oct 14 '22 15:10 Angryman18

the issue is already there #472 i guess @supminn is working on it

Yes, the fixes would be a part of #595

  • #595

supminn avatar Oct 14 '22 16:10 supminn

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Nov 18 '22 12:11 github-actions[bot]

This issue has been fixed. Thus, it can be marked closed.

supminn avatar Nov 18 '22 12:11 supminn

Hi @atapas Could you please close this issue? The fixes have been merged in #595

supminn avatar Nov 28 '22 11:11 supminn

@atapas and @Sachin-chaurasiya Please close this issue as this issue has been merged.

AbhiPatel10 avatar Dec 25 '22 10:12 AbhiPatel10