react-play icon indicating copy to clipboard operation
react-play copied to clipboard

added react-lazy-load on home page

Open crater90 opened this issue 3 years ago • 5 comments

Description

Added Lazy load for individual sections on home page. Though i have lazy loaded only Tweets and Contributors sections because only these sections are dealing with a lot of media and network requests. All the other sections are small, static and aren't sharing resources over network.

Added the react-lazy-load library. Used the Lazyload component provided by library to load the Tweets and Contributors section.

Fixes # (issue)

Type of change

  • [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checked the network requests in Network tab while scrolling.

Steps to reproduce :

  1. Open the Network tab and reload the page.
  2. Before implementation all the resources related to tweets and contributors gets fetched initially.
  3. After implementation resources related to tweets starts getting fetched as the user scrolls to tweet section with an offset of 100px and contributors section with an offset of 50px

Checklist:

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

crater90 avatar Oct 13 '22 12:10 crater90

@crater90 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Oct 13 '22 12:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 29, 2022 at 9:02AM (UTC)

vercel[bot] avatar Oct 14 '22 15:10 vercel[bot]

@koustov @atapas can you please review the code changes...

crater90 avatar Oct 14 '22 18:10 crater90

@koustov @atapas can you please review the code changes...

Yes will do.

atapas avatar Oct 14 '22 18:10 atapas

@crater90 what is the issue this PR is targeting for?

koustov avatar Oct 19 '22 18:10 koustov

@crater90 what is the issue this PR is targeting for?

it's #463 I guess @crater90

murtuzaalisurti avatar Oct 29 '22 08:10 murtuzaalisurti

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Nov 28 '22 12:11 github-actions[bot]