react-play icon indicating copy to clipboard operation
react-play copied to clipboard

#684 - Clean up and reorganized Home.jsx, #685 - Added Twitter error handler and display error message

Open billy-le opened this issue 3 years ago • 5 comments

Description

#684 - moved sections into their own React component to reduce cognitive overload. #685 - added an error handler for when a widget fails to load or when all the widgets fails to load

Fixes #684 Fixes #685

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Only tested locally

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

billy-le avatar Oct 12 '22 07:10 billy-le

@billy-le is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Oct 12 '22 07:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 3:54PM (UTC)

vercel[bot] avatar Oct 14 '22 15:10 vercel[bot]

@atapas @harshsinghatz @koustov hello, I can have someone review these changes?

billy-le avatar Oct 19 '22 02:10 billy-le

@atapas Please review it!

harshsinghatz avatar Oct 19 '22 03:10 harshsinghatz

@atapas are you on it?

koustov avatar Oct 19 '22 18:10 koustov

@billy-le could you please resolve the conflict? I will review post that

koustov avatar Nov 02 '22 15:11 koustov

@koustov okay, it should be updated now

billy-le avatar Nov 05 '22 06:11 billy-le

@billy-le thanks. This seems to be a large change. @atapas I feel its better to engage a QA on this PR before moving it next phase

koustov avatar Nov 07 '22 18:11 koustov