react-play icon indicating copy to clipboard operation
react-play copied to clipboard

Enhance home trending plays

Open ammaaraslam opened this issue 3 years ago • 4 comments

Description

This PR introduces the new trending plays in the home page of React Play. It now displays plays according to the weekly views of a play.

Fixes #500

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Testing through previews

Checklist:

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

ammaaraslam avatar Oct 10 '22 14:10 ammaaraslam

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 23, 2022 at 1:00PM (UTC)

vercel[bot] avatar Oct 10 '22 14:10 vercel[bot]

Note:- The feature is not tested yet, because of security errors with the analytics API and localhost

ammaaraslam avatar Oct 10 '22 14:10 ammaaraslam

@harshsinghatz still working on the PR cuz of security errors in a local build.... so I'm still testing out features and not yet completed with it. Will request a review from you once done

ammaaraslam avatar Oct 11 '22 03:10 ammaaraslam

@harshsinghatz still working on the PR cuz of security errors in a local build.... so I'm still testing out features and not yet completed with it. Will request a review from you once done

Cool!

harshsinghatz avatar Oct 11 '22 03:10 harshsinghatz

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Nov 23 '22 12:11 github-actions[bot]