react-play icon indicating copy to clipboard operation
react-play copied to clipboard
verified publisher icon reactplay

[feat] Add the number badge to the comment icon

Open sudipkundu999 opened this issue 3 years ago • 7 comments

Description

This PR adds the feature of showing the number badge to the comment icon

Fixes #154

Type of change

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This has been tested manually. On opening any play the correct comment count should be displayed. eg. On opening, React-Gradients play it shows 1

Checklist:

  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

sudipkundu999 avatar Oct 09 '22 10:10 sudipkundu999

@sudipkundu999 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Oct 09 '22 10:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 9, 2022 at 10:45AM (UTC)

vercel[bot] avatar Oct 09 '22 10:10 vercel[bot]

Hi @sudipkundu999

Please correct the build error

image

atapas avatar Oct 09 '22 10:10 atapas

@sudipkundu999 Thanks for fixing the build.. However the comment system breaks now

image

atapas avatar Oct 09 '22 10:10 atapas

Visit Preview

Please test it out from the preview build: https://react-play-git-fork-sudipkundu999-issue-154-reactplayio.vercel.app/

atapas avatar Oct 09 '22 10:10 atapas

Visit Preview

Please test it out from the preview build: https://react-play-git-fork-sudipkundu999-issue-154-reactplayio.vercel.app/

Hold on @sudipkundu999

I have found one Giscus env variable was wrongly set on the preview build.. I have now corrected and triggered a build. We both will test on it once it is complete.

atapas avatar Oct 09 '22 10:10 atapas

https://react-play-git-fork-sudipkundu999-issue-154-reactplayio.vercel.app/

Ok commenting works now as I have updated the env correctly..

However the count doesn't work due to the CORS policy on the URL you are tying.

image

I remember, other contributor also faced the similar issue. Please check how to fix it.

atapas avatar Oct 09 '22 11:10 atapas