react-play icon indicating copy to clipboard operation
react-play copied to clipboard

in Gallery.js a setData was initialized but never used so fixed that …

Open Deepakbabani opened this issue 3 years ago • 4 comments

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Made some changes in HackathonBanner.jsx file, in this file there were some unused imports like useState and AiFillGithub so i removed that unused code. In Gallery.js file there was a state setData which was defined but was never in used so now after that filter function the filtered data can be found in result variable and using setData(result) it will reflect on the screen also.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] My changes generate no new warnings
  • [x] New and existing unit tests pass locally with my changes

Deepakbabani avatar Oct 09 '22 07:10 Deepakbabani

Someone is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Oct 09 '22 07:10 vercel[bot]

@Deepakbabani What's the issue.. Please update the title and description properly to start review.

atapas avatar Oct 10 '22 12:10 atapas

@Deepakbabani What's the issue.. Please update the title and description properly to start review.

@Deepakbabani ?

koustov avatar Oct 19 '22 17:10 koustov

@Deepakbabani What's the issue.. Please update the title and description properly to start review.

@Deepakbabani ?

Some warnings were there so i just removed some unused imports in those files.

Deepakbabani avatar Oct 19 '22 18:10 Deepakbabani

@Deepakbabani please resolve the conflicts and assign an issue to this PR

koustov avatar Nov 02 '22 15:11 koustov

Hi @Deepakbabani Please take care of it.

atapas avatar Dec 02 '22 04:12 atapas

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Jan 01 '23 12:01 github-actions[bot]