react-play icon indicating copy to clipboard operation
react-play copied to clipboard

lofi music player

Open riyajath-ahamed opened this issue 3 years ago • 12 comments

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Lofimusic player using React.js and Firebase storage for storing the songs.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

riyajath-ahamed avatar Oct 07 '22 08:10 riyajath-ahamed

@riyajath-ahamed is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Oct 07 '22 08:10 vercel[bot]

@riyajath-ahamed Have you created an issue for it?

atapas avatar Oct 07 '22 09:10 atapas

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 6:47AM (UTC)

vercel[bot] avatar Oct 07 '22 09:10 vercel[bot]

@riyajath-ahamed Have you created an issue for it?

@atapas Not yet

riyajath-ahamed avatar Oct 07 '22 09:10 riyajath-ahamed

@riyajath-ahamed Have you created an issue for it?

@atapas Not yet

Please create one and update the PR description with the issue for the review to strat.

atapas avatar Oct 07 '22 09:10 atapas

@riyajath-ahamed Have you created an issue for it?

@atapas Not yet

Please create one and update the PR description with the issue for the review to strat.

Created

riyajath-ahamed avatar Oct 07 '22 09:10 riyajath-ahamed

@Sachin-chaurasiya Please review this one.

atapas avatar Oct 08 '22 13:10 atapas

@Sachin-chaurasiya Please review this one.

Sure @atapas .

Sachin-chaurasiya avatar Oct 08 '22 13:10 Sachin-chaurasiya

@Sachin-chaurasiya is this review done?

atapas avatar Oct 10 '22 12:10 atapas

@Sachin-chaurasiya is this review done?

@atapas , Yes, I left some comments, Will review again.

Sachin-chaurasiya avatar Oct 10 '22 13:10 Sachin-chaurasiya

@atapas, For me it's LGTM.

Sachin-chaurasiya avatar Oct 11 '22 15:10 Sachin-chaurasiya

@atapas Any changes ?

riyajath-ahamed avatar Oct 15 '22 16:10 riyajath-ahamed

@atapas everything fine ?

riyajath-ahamed avatar Oct 24 '22 14:10 riyajath-ahamed

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Jan 01 '23 12:01 github-actions[bot]