lofi music player
First thing, PLEASE READ THIS: ReactPlay Code Review Checklist
Description
Lofimusic player using React.js and Firebase storage for storing the songs.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
@riyajath-ahamed is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.
@reactplay first needs to authorize it.
@riyajath-ahamed Have you created an issue for it?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| react-play | ✅ Ready (Inspect) | Visit Preview | Nov 14, 2022 at 6:47AM (UTC) |
@riyajath-ahamed Have you created an issue for it?
@atapas Not yet
@riyajath-ahamed Have you created an issue for it?
@atapas Not yet
Please create one and update the PR description with the issue for the review to strat.
@riyajath-ahamed Have you created an issue for it?
@atapas Not yet
Please create one and update the PR description with the issue for the review to strat.
Created
@Sachin-chaurasiya Please review this one.
@Sachin-chaurasiya Please review this one.
Sure @atapas .
@Sachin-chaurasiya is this review done?
@Sachin-chaurasiya is this review done?
@atapas , Yes, I left some comments, Will review again.
@atapas, For me it's LGTM.
@atapas Any changes ?
@atapas everything fine ?
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!