react-play icon indicating copy to clipboard operation
react-play copied to clipboard

creation of a new play called image app and setting it up although ha…

Open obinneji opened this issue 3 years ago • 2 comments

Created a new play called image app but I'm having issues with routing the app.

Description

Created a new plat that needs routing. In this app i want to use react-router-dom to route from the home to login page,sign-up page then user account page. I have used the BrowerRouter hook to wrap my app.js and then used Routes and Route in my app.js. The issue im having is that my app isn't running. It gives a message "cant render a router inside a router".

Issue no: #615

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

obinneji avatar Oct 07 '22 04:10 obinneji

Someone is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Oct 07 '22 04:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 7:24PM (UTC)

vercel[bot] avatar Oct 19 '22 17:10 vercel[bot]

@obinneji Is it ready for review?

atapas avatar Oct 29 '22 03:10 atapas

Not ready yet

On Sat, Oct 29, 2022, 4:47 AM Tapas Adhikary @.***> wrote:

@obinneji https://github.com/obinneji Is it ready for review?

— Reply to this email directly, view it on GitHub https://github.com/reactplay/react-play/pull/630#issuecomment-1295715811, or unsubscribe https://github.com/notifications/unsubscribe-auth/AU5XZAWM46BZU7DFPRUC2KLWFSM6FANCNFSM6AAAAAAQ7G3TSM . You are receiving this because you were mentioned.Message ID: @.***>

obinneji avatar Oct 29 '22 04:10 obinneji

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Nov 28 '22 12:11 github-actions[bot]

@obinneji Are you working on this one?

atapas avatar Dec 02 '22 04:12 atapas

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Jan 02 '23 12:01 github-actions[bot]