New Play: Inspirational Quotes
First thing, PLEASE READ THIS: ReactPlay Code Review Checklist
Description
This typescript app contains motivational quotes. This app has over 250 carefully chosen quotes to motivate users. I did not produce quotations using any API. I have hand-picked these relevant quotes.
Fixes # 608
Type of change
New Play
How Has This Been Tested?
This has been tested locally
ToDo
- [x] Remove play cover metadata which was provided initially.
Checklist:
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
Screenshot
@atapas @koustov I need little help with the last pending ToDo. I provided a cover link while creating the play. But that seems to be invalid. Now I want to use cover.png. Can you please remove the metadata from the backend? I can able find a way to edit the metadata. Let me know if you need any information.
@muzaffar640 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.
@reactplay first needs to authorize it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| react-play | ✅ Ready (Inspect) | Visit Preview | Dec 2, 2022 at 4:47AM (UTC) |
@muzaffar640 Done, please check and confirm.
@muzaffar640 Done, please check and confirm.
Thanks, @atapas for the quick reply. Yes, it has been updated. I have opened the PR for review. 🚀
thanks, @atapas for the review. Addressed all your comments. Review Ready.
@Sachin-chaurasiya thank you for your review. All your comments have been addressed. Review Ready.
@muzaffar640
Please respond to the review comments with a "Done" so that we know it is ready to re-review.
Review Ready.
@atapas , PR is ready to merge.
@muzaffar640 , Can you address the pending comments?
@muzaffar640 , Can you address the pending comments?
@Sachin-chaurasiya there is only one pending comment in this PR. I can't able to resolve it on my own and ask for help. Please refer to this thread and let me know how to proceed.
@muzaffar640 , Can you address the pending comments?
@Sachin-chaurasiya there is only one pending comment in this PR. I can't able to resolve it on my own and ask for help. Please refer to this thread and let me know how to proceed.
@muzaffar640 , This one is pending can you address it? https://github.com/reactplay/react-play/pull/609#discussion_r987592467
@muzaffar640 , Can you address the pending comments?
@Sachin-chaurasiya there is only one pending comment in this PR. I can't able to resolve it on my own and ask for help. Please refer to this thread and let me know how to proceed.
@muzaffar640 , This one is pending can you address it? #609 (comment)
@muzaffar640 Can you please take a look? It's very close to merge.
@muzaffar640 , Can you address the pending comments?
@Sachin-chaurasiya there is only one pending comment in this PR. I can't able to resolve it on my own and ask for help. Please refer to this thread and let me know how to proceed.
@muzaffar640 , This one is pending can you address it? #609 (comment)
@muzaffar640 Can you please take a look? It's very close to merge.
@atapas #609 (comment) has already been resolve. It looks like it has not but if you click on the page you will see the updated code.