react-play icon indicating copy to clipboard operation
react-play copied to clipboard

Published 20 hours ago • verified publisher icon reactplay

feat: support to select multiple filters

Open supminn opened this issue 2 years ago • 7 comments

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Previously, only a combination of 1 level, 1 creator, and 1 Tag was available at a time. I have implemented the option to select multiple values of each combination. (Screenshot attached below)

Fixes # (issue)

  • #24
  • #472
  • #696
  • Partially fixes #192. Filter options are displayed in a sorted manner.

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Screenshots

image image

supminn avatar Oct 03 '22 12:10 supminn

@supminn is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Oct 03 '22 12:10 vercel[bot]

Hey @koustov Please take a look.

atapas avatar Oct 08 '22 12:10 atapas

Hey @koustov Please take a look.

@supminn do you still have the issue? I have already published the package as I mentioned in this pr

koustov avatar Oct 11 '22 19:10 koustov

Hey @koustov Please take a look.

@supminn do you still have the issue? I have already published the package as I mentioned in this pr

Hi @koustov I didn't get a chance to work on this for the last 2-3 days. I'll work on it and update you by tomorrow EOD.

supminn avatar Oct 12 '22 04:10 supminn

Hi @koustov I am facing a few blockers while working with the latest changes. I have mentioned the details on discord. Could you please let me know a suitable time to connect in this regard?

supminn avatar Oct 16 '22 17:10 supminn

@supminn is it ready to be reviewed?

koustov avatar Oct 19 '22 17:10 koustov

@supminn is it ready to be reviewed?

Yes @koustov, could you please review the changes. I had dropped a message on #pr_review in discord.

supminn avatar Oct 20 '22 02:10 supminn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 8:35AM (UTC)

vercel[bot] avatar Oct 31 '22 08:10 vercel[bot]