added a new project: Tic Tac Toe

[joshi-kaushal]

Description

I have added a new beginner level project: Tic Tac Toe. It focuses on useState hook and cretes a two player tic tac toe game

Note: I have added three more packages: react-toastify, react-icons and reactstrap.

Fixes issue #60: TicTacToe

Type of change

Please delete options that are not relevant.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How Has This Been Tested?

iT wOrKs On My MaChIne nothing particular

Checklist:

• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules

[vercel[bot]]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/atapas/react-play/EeDk658wy1N2c8hjZugZURWTaSon
✅ Preview: https://react-play-git-fork-joshi-kaushal-tic-tac-toe-atapas.vercel.app

[atapas]

Hello @joshi-kaushal

Thanks a lot for the PR. Could you please create an issue for this PR and link them?

[joshi-kaushal]

oh I totally forgot that, created a new issue, could you please take a look and assign it to me

[atapas]

oh I totally forgot that, created a new issue, could you please take a look and assign it to me

Done.. Can we start reviewing it?

[atapas]

Hello @joshi-kaushal

We have upgraded to React v18 as part of this issue: https://github.com/atapas/react-play/issues/87

We have tested the existing plays. All good. Please pull this change to your branch and keep it up-to-date. You have to do sanity of things to make sure everything works for your changes in your branch.

Happy Coding!

[atapas]

@joshi-kaushal Once you done, please remove the work-in-progress label and review-ready label so that we can start the review.

[vercel[bot]]

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
react-play	❌ Failed (Inspect)			Mar 19, 2023 at 4:25PM (UTC)

[joshi-kaushal]

Hello @atapas, I have made required changes, please have a look.

[atapas]

I'm not going to request change, cuz I'm not sure I can do this here, but I left comments that I think should be addressed

You can surely. That's the fun of ReactPlay, we all learn together 🙌

[joshi-kaushal]

I'm not going to request change, cuz I'm not sure I can do this here, but I left comments that I think should be addressed

Hey, thanks man! I really appreciate this. I had built this in my initial learning days, hence so much spaghetti code. I will make these changes ASAP.

Thanks again, looking forward fo more reviews :)

[kirillkurko]

Hey, thanks man! I really appreciate this. I had built this in my initial learning days, hence so much spaghetti code. I will make these changes ASAP.

Thanks again, looking forward fo more reviews :)

I see, cool, I will try to be helpful with my reviews

[kirillkurko]

You can surely. That's the fun of ReactPlay, we all learn together 🙌

Cool, I will try to become a reviewer

[atapas]

@joshi-kaushal Once you taken care of the comments, please resolve them by saying done. This will help me to do a final review once all the existing comments are done. Looking forward to it.

[joshi-kaushal]

I have a free time after my exam of 18th. I will finish remaining tasks later.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

---

From: Tapas Adhikary @.> Sent: Monday, May 16, 2022 9:52:47 AM To: atapas/react-play @.> Cc: Kaushal Joshi @.>; Mention @.> Subject: Re: [atapas/react-play] added a new project: Tic Tac Toe (PR #59)

@joshi-kaushalhttps://github.com/joshi-kaushal Once you taken care of the comments, please resolve them by saying done. This will help me to do a final review once all the existing comments are done. Looking forward to it.

— Reply to this email directly, view it on GitHubhttps://github.com/atapas/react-play/pull/59#issuecomment-1127203456, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMUXRSX453VU56QE5DWNEZDVKHERPANCNFSM5TYPSF5Q. You are receiving this because you were mentioned.Message ID: @.***>

[atapas]

I have a free time after my exam of 18th. I will finish remaining tasks later.

Sounds perfect. All the best for the exam.

[atapas]

Hello @joshi-kaushal

We will be moving the react-play project from the atapas account to an organization to help manage the project in a better way. The new organization URL is: https://github.com/reactplay.

The movement will take place between 12:30 - 14:00 hrs IST(7:00 am - 8:30 am GMT), 30th May 2022. Please refrain from pushing any changes between this time.

We will inform you when the movement is complete. You need to make a few minimal configuration changes after that. We will let you know.

[joshi-kaushal]

@atapas

Sure, keep me updated. I haven't been able to make changes since the last time we discussed so everything must be clear from my side.

[atapas]

Hello @joshi-kaushal

We will be moving the react-play project from the atapas account to an organization to help manage the project in a better way. The new organization URL is: https://github.com/reactplay.

The movement will take place between 12:30 - 14:00 hrs IST(7:00 am - 8:30 am GMT), 30th May 2022. Please refrain from pushing any changes between this time.

We will inform you when the movement is complete. You need to make a few minimal configuration changes after that. We will let you know.

The migration is complete. You can find the project here: https://github.com/reactplay

You no need to reclone the project. You just need to set the correct upstream. Here is the link: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-for-a-fork

[joshi-kaushal]

Hello @atapas and @kirillkurko, I have made the requested changes.

[atapas]

@joshi-kaushal

• Pull the main
• Resolve merge conflicts
• COmment on each of the comments mentioning "done" or not done.

Lets close this one asap.

[joshi-kaushal]

@atapas everything is clear from my side, ready for final review!

[koustov]

@joshi-kaushal please pull the main and resolve conflicts. Also, let us know if it is review-ready?

[joshi-kaushal]

@koustov everything is clear from my side.

[koustov]

@koustov everything is clear from my side.

@joshi-kaushal I see some comments are addressed however few others are not. These are just marked as Resolved. So I am not sure what is the fate of those comments.

I would suggest, if you don't agree to any comment, give a proper justification and then mark resolved. Similar way, if a comment has been addressed, at minimum one should reply by saying done and resolve it.

[joshi-kaushal]

I forgot to push one change but other than that I believe I have made every change you asked for. I don't reply done everywhere to avoid spam.

I will keep these things in mind the next time.

If there is still some comment that I have resolved but haven't acknowledged, I have done it by mistake.

[atapas]

Hi @joshi-kaushal

We have some massive changes in the data store and we are changing how the play gets created for a better usability. As this play is interim, we need to make sure it migrates correctly. Could you please ping me on Discord so that I make sure everything is placed?

https://discord.gg/YbmXwU5f

[koustov]

Hey @joshi-kaushal once you are done with merge-conflict, please notify us on 👍-play-review channel

[joshi-kaushal]

@koustov I am ill. it will take me three or four days to do this. I hope that's fine.

[koustov]

@koustov I am ill. it will take me three or four days to do this. I hope that's fine.

no problem. health first. take care