react-play icon indicating copy to clipboard operation
react-play copied to clipboard

Issue-429-edit-play-flow

Open Angryman18 opened this issue 3 years ago • 4 comments

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Angryman18 avatar Aug 29 '22 14:08 Angryman18

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 3:36PM (UTC)

vercel[bot] avatar Aug 29 '22 14:08 vercel[bot]

this PR is still under construction. why are there reviews?

Angryman18 avatar Oct 01 '22 06:10 Angryman18

this PR is still under construction. why are there reviews?

@Angryman18 , If PR is under construction then please make it a draft PR and Change the title of the PR by adding the WIP prefix.

Sachin-chaurasiya avatar Oct 01 '22 06:10 Sachin-chaurasiya

@Angryman18 , You can use this guide for the same https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request

Sachin-chaurasiya avatar Oct 01 '22 06:10 Sachin-chaurasiya

Deploy Preview for reactplayio ready!

Name Link
Latest commit 03ecf692cdcfb6368a54dd75c92c3c11c64e9fb8
Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/637ceb3712695000089113c5
Deploy Preview https://deploy-preview-532--reactplayio.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Nov 21 '22 14:11 netlify[bot]