react-play icon indicating copy to clipboard operation
react-play copied to clipboard

Added Cypress test for home page

Open ShaileshParmar11 opened this issue 3 years ago • 3 comments

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

I have added basic test case for home page

Fixes #503

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Locally tested Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

ShaileshParmar11 avatar Aug 24 '22 15:08 ShaileshParmar11

@ShaileshParmar11 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Aug 24 '22 15:08 vercel[bot]

PR is ready for review

ShaileshParmar11 avatar Aug 24 '22 15:08 ShaileshParmar11

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ❌ Failed (Inspect) Aug 24, 2022 at 6:23PM (UTC)

vercel[bot] avatar Aug 24 '22 18:08 vercel[bot]

Deployment error image

@ShaileshParmar11 can you check

koustov avatar Aug 25 '22 18:08 koustov

Deployment error image

@ShaileshParmar11 can you check

I dont think it is something related to cypress can you retry deploying?

ShaileshParmar11 avatar Aug 25 '22 18:08 ShaileshParmar11

@ShaileshParmar11 The buils issue is successful. The test continues to fail though

atapas avatar Aug 27 '22 13:08 atapas

It is running test from main branch, once this pr is merged it will be resolved

ShaileshParmar11 avatar Aug 27 '22 13:08 ShaileshParmar11