react-play icon indicating copy to clipboard operation
react-play copied to clipboard

Published 20 hours ago • verified publisher icon reactplay

add star rating play

Open frankiefab100 opened this issue 2 years ago • 3 comments

This fixes issue #464

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

A Star rating play shows the use of useState hook

Fixes #464

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Locally on localhost

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

frankiefab100 avatar Aug 20 '22 21:08 frankiefab100

@frankiefab100 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

vercel[bot] avatar Aug 20 '22 21:08 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Sep 2, 2022 at 4:30AM (UTC)

vercel[bot] avatar Aug 21 '22 05:08 vercel[bot]

Few early impression

  1. Unwanted vertical and horizontal; scrollbar appearing
  2. It would be great if you can associate some titles with each start. something like "Bad", "Not OK", "Good", "Very Good", "Spelbound"
  3. it would be even better if you can give me some options to choose from. Like you have already implemented with star, probably another option would be smilies and so on

No 1 is mandatory to fix whereas No 2 and No 3, I would leave with you. Once done I can start reviewing.

Alright

frankiefab100 avatar Aug 22 '22 15:08 frankiefab100

Hey @frankiefab100 , let us know when its ready

koustov avatar Aug 25 '22 18:08 koustov

Hey @frankiefab100 , let us know when its ready

Hi @koustov I have made the necessary changes

frankiefab100 avatar Aug 27 '22 14:08 frankiefab100

@frankiefab100 let's close this one soon and get in.

atapas avatar Sep 01 '22 03:09 atapas

@frankiefab100 let's close this one soon and get in.

I pushed new commits yesterday. Waiting for a review

frankiefab100 avatar Sep 01 '22 08:09 frankiefab100

@frankiefab100 let's close this one soon and get in.

I pushed new commits yesterday. Waiting for a review

Ok @koustov will close it then tonight.

atapas avatar Sep 01 '22 10:09 atapas

Only comment image

Fabulous job @frankiefab100

Thank you 😄

frankiefab100 avatar Sep 02 '22 11:09 frankiefab100