Change webiste title dynamically

[ammaaraslam]

Description

Added functionality to dynamically change the title of the website according to the page. If the user is on the ideas page, then the title of the page is "ReactPlay - Ideas"

Fixes #495

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested Locally.

Checklist:

• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-play	✅ Ready (Inspect)	Visit Preview	Aug 27, 2022 at 1:32PM (UTC)

[ammaaraslam]

I found that in production, the title changes on the play page but not on other pages. Please wait till I find a fix..Thanks

[ammaaraslam]

@atapas and @koustov, the issue has been fixed and this PR is now ready for review.

[atapas]

@ammaaraslam

The build fails with this error

Creating an optimized production build...

14:13:31.965 | Failed to compile. 14:13:31.966 |   14:13:31.966 | Module not found: Error: Package path ./dist/loader/css/react-spinner-loader.css is not exported from package /vercel/path0/node_modules/react-loader-spinner (see exports field in /vercel/path0/node_modules/react-loader-spinner/package.json)

[ammaaraslam]

@ammaaraslam

The build fails with this error

Creating an optimized production build...

14:13:31.965 | Failed to compile. 14:13:31.966 |   14:13:31.966 | Module not found: Error: Package path ./dist/loader/css/react-spinner-loader.css is not exported from package /vercel/path0/node_modules/react-loader-spinner (see exports field in /vercel/path0/node_modules/react-loader-spinner/package.json)

That's weird, it got published yesterday, let me check.

[ammaaraslam]

Hi @atapas. I don't seem to figure out why the build is failing. The build is failing after you have merged from the main branch. Perhaps a change from that is what causing the build to fail. Could you check on that and let me know.

[atapas]

Hi @atapas. I don't seem to figure out why the build is failing. The build is failing after you have merged from the main branch. Perhaps a change from that is what causing the build to fail. Could you check on that and let me know.

Yeah I see in general all build fails today due to the same error. Now sure if there is a new version of react-loader-spinner library that is broken. Do you want to check that out locally with a yarn build?

[atapas]

Hi @atapas. I don't seem to figure out why the build is failing. The build is failing after you have merged from the main branch. Perhaps a change from that is what causing the build to fail. Could you check on that and let me know.

Yeah I see in general all build fails today due to the same error. Now sure if there is a new version of react-loader-spinner library that is broken. Do you want to check that out locally with a yarn build?

As suspected it is an issue with the library. They have published a new version and it is breaking things. I see an open issue already. Until they fix the open issue, please revert the version back to what was working and fix to it.

https://github.com/mhnpd/react-loader-spinner/issues/135

[ammaaraslam]

@atapas, I have reverted the version of react-loader-spinner and now the build is a success.

[atapas]

Visit Preview

Yes, I see that.. let's create an issue and fix this one alone so that we can merge it to unblock other branches.

[ammaaraslam]

Visit Preview

Yes, I see that.. let's create an issue and fix this one alone so that we can merge it to unblock other branches.

@atapas, I have created an issue and PR to fix this issue.

[ammaaraslam]

@atapas and @koustov. This PR is now ready for review, I have made changes to simplify the logic as Tapas suggested