react-play icon indicating copy to clipboard operation
react-play copied to clipboard

feature: configured ESLint/Prettier/Husky setup

Open joshi-kaushal opened this issue 3 years ago • 5 comments

Description

Fixes #263 I previously raised a similar PR #332, but this is the latest and better version of the issue.

This PR integrates Husky, Prettier, and ESLint with the repository. This will test staged files against the config before every commit.
The existing files are yet to be fixed. I believe in creating a different branch and collaboratively resolving those errors/warnings for doing it.

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

joshi-kaushal avatar Aug 19 '22 15:08 joshi-kaushal

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ❌ Failed (Inspect) Nov 25, 2022 at 8:37AM (UTC)

vercel[bot] avatar Aug 19 '22 15:08 vercel[bot]

I see this build time error image

koustov avatar Aug 20 '22 19:08 koustov

Hey @joshi-kaushal i would like to get this PR in. A long-time one. Could you please resolve the conflict and fix the build error? Then it will be ready for merge.

koustov avatar Aug 30 '22 19:08 koustov

Hello @koustov, I am busy with a few other things rn. It would be really helpful if anyone could help me with this pr.

joshi-kaushal avatar Aug 31 '22 18:08 joshi-kaushal

Hi @koustov

I can not see the preview or error log for this build. Where can I see those?

joshi-kaushal avatar Sep 05 '22 18:09 joshi-kaushal

@Sachin-chaurasiya

  • remove husky (kaushal) (09/11)
  • merge sachin's eslint configuration with pr #507 (sachin) (11/11)
  • merge #507 with main (tapas) (12/11)
  • start resolving eslint/etc on #768 (core) (19/11)
  • re-configure husky (kaushal/sachin) (20/11)

joshi-kaushal avatar Nov 08 '22 14:11 joshi-kaushal

  • kaushal)

Nice! Can we put dates also on these tasks by when we can tentatively complete them?

atapas avatar Nov 08 '22 15:11 atapas

Deploy Preview for reactplayio failed.

Name Link
Latest commit 1fd1dba1be4835be042d41d3deac6a85c4d13f93
Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6380506435a7820009a8b85e

netlify[bot] avatar Nov 24 '22 05:11 netlify[bot]