🐛 [Bug report]: Filter plays including tag is making no impact

[Angryman18]

If we filter a play by tags it works but if we filter the plays with tags with a combination of other criteria, the tag selection is of no use as it never impact the criteria.

Screencast from 09-08-22 02:15:36 PM IST.webm

[dangvu0502]

Hello Is this still available for contribution? I'd love to work on it

[atapas]

Hello Is this still available for contribution? I'd love to work on it

Yes plz

[dangvu0502]

I found this issue was caused by package "json-graphql-parser".

this is how i debugged https://drive.google.com/file/d/15vVL2Tx5d-esUTAfjhlMlIyE3fBlvn-Y/view

this is how "json-graphql-parser" work https://drive.google.com/file/d/11AKK1CLj9h4WSQqPrMfMVN4PM_cy4UV9/view

[atapas]

I found this issue was caused by package "json-graphql-parser".

this is how i debugged https://drive.google.com/file/d/15vVL2Tx5d-esUTAfjhlMlIyE3fBlvn-Y/view

this is how "json-graphql-parser" work https://drive.google.com/file/d/11AKK1CLj9h4WSQqPrMfMVN4PM_cy4UV9/view

Can you please give access to the docs?

[dangvu0502]

access granted

[Angryman18]

give access

[Angryman18]

i wonder how this can be an issue from a package since filtering with tags doesnt even make any graphql call.

thus i think its more of a issue of the api call.

[dangvu0502]

Hmm... if you take a look at video how "json-graphql-parser" work. You can see when you filter the plays with tags with a combination of other criteria, it throws error. "json-graphql-parser" can not parse obj to graphql query, i think this error affect api call.

[Angryman18]

thanks for noticing it. @koustov will be up there to fix it.

[koustov]

I will look into it some time. BTW, this is another open-source element, https://github.com/koustov/json-graphql-parser feel free to update if you face any issue

[Angryman18]

yes i checked yesterday and found the issue. its coming from processor.js and line number 101 where code is trying to push something inside an object instead of an array. i am still weak in graphql so i couldn't go further to fix it.

[atapas]

Hello @dangvu0502 Thanks for the initial research. Will you take up for fixing it?

[dangvu0502]

Hmm.... I'm still researching to find the solution but no progress. I think it is better to leave for someone good at graphql

[Angryman18]

is this being take care?

[dangvu0502]

Please assign this issue to someone else as I will not be able to work on this

[Hat52]

I would like to work on this issue

[supminn]

I will look into it sometime. BTW, this is another open-source element, https://github.com/koustov/json-graphql-parser feel free to update if you face any issue

Hi @koustov I have raised the issue on json-graphql-parser and the PR for its fix.

[Hat52]

So you are saying that you have already resolved the issue?

[supminn]

So you are saying that you have already resolved the issue?

Yes @Hat52 , the issue was on json-graphql-parser. I have raised a PR with the fixes.