reactplay
New user trial. -- per discussion with atapas
First thing, PLEASE READ THIS: ReactPlay Code Review Checklist
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
@james-david-marks is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.
@reactplay first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| react-play | ✅ Ready (Inspect) | Visit Preview | Jul 16, 2022 at 4:29PM (UTC) |
Hello @james-david-marks, can you get yourself logged in at https://rgkjmwftqtbpayoyolwh.nhost.run/v1/auth/signin/provider/github. This will make sure that you are onboarded with reactplay and then the play that you added can be inserted into the list.
Hello @james-david-marks, can you get yourself logged in at https://rgkjmwftqtbpayoyolwh.nhost.run/v1/auth/signin/provider/github. This will make sure that you are onboarded with reactplay and then the play that you added can be inserted into the list.
To continue your development, I have temporarily added your play under my account so that it starts appearing in your playlist
. Let me know once your login/registration process is over, I will transfer it to your account.
Koustov,
Thank you. I went to the link and authorized my github account. I think everything is in order. Do I understand correctly that I will not see my play until I do a PR? Anyway, I see it now. As you have already advised, it says you are the author now. As you have also advised, you will change it now that I have onboarded. Thank you for addressing this.
Jim
From: Koustov Sent: Sunday, July 17, 2022 12:17 AM To: reactplay/react-play @.> Cc: james-david-marks @.>; Mention @.***> Subject: Re: [reactplay/react-play] New user trial. -- per discussion with atapas (PR #378)
Hello @james-david-marks https://github.com/james-david-marks , can you get yourself logged in at https://rgkjmwftqtbpayoyolwh.nhost.run/v1/auth/signin/provider/github. This will make sure that you are onboarded with reactplay and then the play that you added can be inserted into the list.
To continue your development, I have temporarily added your play under my account so that it starts appearing in your playlist https://user-images.githubusercontent.com/7145967/179384942-ba47a8f4-458b-4ff3-a64c-cca51707b6a9.png
. Let me know once your login/registration process is over, I will transfer it to your account.
— Reply to this email directly, view it on GitHub https://github.com/reactplay/react-play/pull/378#issuecomment-1186404961 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAY2BKWJ67XE3PE6APAZMDVUOJL5ANCNFSM53YJ7VSQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABAY2BIFBBVE4KJMWMP52NTVUOJL5A5CNFSM53YJ7VS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI23RUYI.gif Message ID: @.*** @.***> >
Koustov, Thank you. I went to the link and authorized my github account. I think everything is in order. Do I understand correctly that I will not see my play until I do a PR? Anyway, I see it now. As you have already advised, it says you are the author now. As you have also advised, you will change it now that I have onboarded. Thank you for addressing this. Jim From: Koustov Sent: Sunday, July 17, 2022 12:17 AM To: reactplay/react-play @.> Cc: james-david-marks @.>; Mention @.> Subject: Re: [reactplay/react-play] New user trial. -- per discussion with atapas (PR #378) Hello @james-david-marks https://github.com/james-david-marks , can you get yourself logged in at https://rgkjmwftqtbpayoyolwh.nhost.run/v1/auth/signin/provider/github. This will make sure that you are onboarded with reactplay and then the play that you added can be inserted into the list. To continue your development, I have temporarily added your play under my account so that it starts appearing in your playlist https://user-images.githubusercontent.com/7145967/179384942-ba47a8f4-458b-4ff3-a64c-cca51707b6a9.png . Let me know once your login/registration process is over, I will transfer it to your account. — Reply to this email directly, view it on GitHub <#378 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAY2BKWJ67XE3PE6APAZMDVUOJL5ANCNFSM53YJ7VSQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABAY2BIFBBVE4KJMWMP52NTVUOJL5A5CNFSM53YJ7VS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI23RUYI.gif Message ID: @. @.***> >
Firstly, you are welcome
- Do I understand correctly that I will not see my play until I do a PR?: Not really, we can do this stem early also, anyway its a temporary step. We are making it automated and the beta testing is going on
- As you have already advised, it says you are the author now. As you have also advised, you will change it now that I have onboarded: Yes, it has been transferred to your account now
Many thanks again. I like what you guys are doing. I have already learned a fair amount of react just noodling around in the existing plays. :)
Sent from my iPhone
On Jul 17, 2022, at 9:39 PM, Koustov @.***> wrote:
Koustov, Thank you. I went to the link and authorized my github account. I think everything is in order. Do I understand correctly that I will not see my play until I do a PR? Anyway, I see it now. As you have already advised, it says you are the author now. As you have also advised, you will change it now that I have onboarded. Thank you for addressing this. Jim From: Koustov Sent: Sunday, July 17, 2022 12:17 AM To: reactplay/react-play @.> Cc: james-david-marks @.>; Mention @.> Subject: Re: [reactplay/react-play] New user trial. -- per discussion with atapas (PR #378) Hello @james-david-marks https://github.com/james-david-marks , can you get yourself logged in at https://rgkjmwftqtbpayoyolwh.nhost.run/v1/auth/signin/provider/github. This will make sure that you are onboarded with reactplay and then the play that you added can be inserted into the list. To continue your development, I have temporarily added your play under my account so that it starts appearing in your playlist https://user-images.githubusercontent.com/7145967/179384942-ba47a8f4-458b-4ff3-a64c-cca51707b6a9.png . Let me know once your login/registration process is over, I will transfer it to your account. — Reply to this email directly, view it on GitHub <#378 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAY2BKWJ67XE3PE6APAZMDVUOJL5ANCNFSM53YJ7VSQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABAY2BIFBBVE4KJMWMP52NTVUOJL5A5CNFSM53YJ7VS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOI23RUYI.gif Message ID: @. @.***> >
Firstly, you are welcome
Do I understand correctly that I will not see my play until I do a PR?: Not really, we can do this stem early also, anyway its a temporary step. We are making it automated and the beta testing is going on As you have already advised, it says you are the author now. As you have also advised, you will change it now that I have onboarded: Yes, it has been transferred to your account now — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.
Many thanks again. I like what you guys are doing. I have already learned a fair amount of react just noodling around in the existing plays. :) …
Great 👍
Looking forward to your play.
Hey @james-david-marks We have the new create flow up and running. You can give that a try too.
Hello @james-david-marks
A reminder to get back on this play. This PR may be closed due to a lack of activities soon. Please let us know if you need any help.
Looking forward to getting the play in!