react-play icon indicating copy to clipboard operation
react-play copied to clipboard

🐛 [Bug report]: Normalize the backend API calls

Open atapas opened this issue 3 years ago • 5 comments

Describe the bug

The Home page makes the call to list all the plays but we do not use it in the Home page. Ideally,

  • Home page should make the "Featured" play call
  • The play list page should make the all plays call with minimalistic data required for the thumbnails.
  • Each of the play details should retrieve all required data for a play.

atapas avatar Jun 26 '22 17:06 atapas

can I help with this issue?

6km avatar Jul 19 '22 11:07 6km

i guess it is being managed by #371

Angryman18 avatar Jul 19 '22 11:07 Angryman18

Screencast from 25-07-22 07:31:38 PM IST.webm

this issue isnt solved i guess.

Angryman18 avatar Jul 25 '22 14:07 Angryman18

Screencast.from.25-07-22.07.31.38.PM.IST.webm this issue isnt solved i guess.

@Angryman18 , I didn't get the issue . Are you saying that, there shouldn't be any more API calls to list PLAYS once its done in /plays route? Please explain

koustov avatar Aug 02 '22 02:08 koustov

yes that was what i tried to show there. I think we dont make the call when user goes into a play but if user landing directly on a play only then we should me making the api call ?

Angryman18 avatar Aug 02 '22 03:08 Angryman18

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Nov 25 '22 12:11 github-actions[bot]

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Oct 26 '23 12:10 github-actions[bot]