react-play icon indicating copy to clipboard operation
react-play copied to clipboard

✨ [Feature request]: Add a link to navigate to all plays

Open vasantisuthar opened this issue 3 years ago • 17 comments

Add a link to navigate to all plays when play is not found

2022-06-05 (2)

It would be good if we add a text that will link to all the plays back when the play is not found.

I would like to work on this issue.

vasantisuthar avatar Jun 05 '22 11:06 vasantisuthar

@vasantisuthar , One more thing we can do here is instead of play not found , we can say play not found for {searchText}.

Sachin-chaurasiya avatar Jun 06 '22 03:06 Sachin-chaurasiya

One more thing we can create two buttons one for the home page and the other is for plays page

MOHAMED-EHAB-DEV avatar Jun 07 '22 16:06 MOHAMED-EHAB-DEV

There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

vasantisuthar avatar Jun 07 '22 18:06 vasantisuthar

There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

But you are already on the plays page when this message appears. How about that?

atapas avatar Jun 09 '22 02:06 atapas

There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

Ok 👌

MOHAMED-EHAB-DEV avatar Jun 09 '22 06:06 MOHAMED-EHAB-DEV

There is already a React play home button at the top, we shall only include all plays button, what say @Sachin-chaurasiya @Programming-School-Pro-Coding

But you are already on the plays page when this message appears. How about that?

In the 404 react file we will add new button

MOHAMED-EHAB-DEV avatar Jun 09 '22 06:06 MOHAMED-EHAB-DEV

@vasantisuthar , One more thing we can do here is instead of play not found , we can say play not found for {searchText}.

@atapas , Your thought on this.

Sachin-chaurasiya avatar Jun 09 '22 06:06 Sachin-chaurasiya

@Sachin-chaurasiya

I think we shouldn't overengineer this one. A reasonable fix to me is to enhance the message with the search text as you suggested. Can we get it done? I see the issue has been assigned to @vasantisuthar

atapas avatar Jun 30 '22 02:06 atapas

@Sachin-chaurasiya

I think we shouldn't overengineer this one. A reasonable fix to me is to enhance the message with the search text as you suggested. Can we get it done? I see the issue has been assigned to @vasantisuthar

@atapas , Yes.

Sachin-chaurasiya avatar Jun 30 '22 03:06 Sachin-chaurasiya

@vasantisuthar , Let me know, and I can pick this up.

Sachin-chaurasiya avatar Jun 30 '22 14:06 Sachin-chaurasiya

Okay so I can update the text message.

vasantisuthar avatar Jun 30 '22 19:06 vasantisuthar

@vasantisuthar / @Sachin-chaurasiya this issue is around for a long time. Can any of you please take care?

atapas avatar Aug 02 '22 02:08 atapas

@vasantisuthar / @Sachin-chaurasiya this issue is around for a long time. Can any of you please take care?

Sure @atapas, @vasantisuthar let me know if you need any help on this.

Sachin-chaurasiya avatar Aug 02 '22 05:08 Sachin-chaurasiya

@Sachin-chaurasiya does it really need to be modified, I guess we shouldn't now as the page looks clear to me.

vasantisuthar avatar Aug 02 '22 06:08 vasantisuthar

@Sachin-chaurasiya does it really need to be modified, I guess we shouldn't now as the page looks clear to me.

@vasantisuthar , we can do something like this if there is a search term.

image

Sachin-chaurasiya avatar Aug 02 '22 06:08 Sachin-chaurasiya

Cool I will do it, I tried to do it before but the search bar wasn't shown up on the browser, so waited for that.

vasantisuthar avatar Aug 02 '22 07:08 vasantisuthar

Cool I will do it, I tried to do it before but the search bar wasn't shown up on the browser, so waited for that.

Will submit this on Sunday

vasantisuthar avatar Aug 04 '22 19:08 vasantisuthar

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Dec 07 '22 12:12 github-actions[bot]

already added

priyankarpal avatar Oct 07 '23 13:10 priyankarpal