react-play icon indicating copy to clipboard operation
react-play copied to clipboard

new play youtube-clone created

Open Srinu126 opened this issue 3 years ago • 13 comments

Description

#Youtube Clone I have created a simple Video viewer app similar to Youtube. I am making use of google api to fetch the videos. The user can search for the videos and once he submit the search key, the videos will be fetched and rendered on the UI. Fixes # (issue) This is a new Play and it is not breaking any existing code. And also, I believe there is still some css changes to be made and I will be working on that.

Type of change

Please delete options that are not relevant.

  • [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

Srinu126 avatar May 17 '22 13:05 Srinu126

Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel.

@atapas first needs to authorize it.

vercel[bot] avatar May 17 '22 13:05 vercel[bot]

@atapas could you please review and approve the pull request. Thanks !

Srinu126 avatar May 17 '22 13:05 Srinu126

@Srinu126 please create an issue for this PR and add in the PR description. Also, please read through the check list for your reference: https://github.com/atapas/react-play/wiki/ReactPlay-Code-Review-Checklist

atapas avatar May 17 '22 13:05 atapas

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview May 17, 2022 at 1:46PM (UTC)

vercel[bot] avatar May 17 '22 13:05 vercel[bot]

@Srinu126 please create an issue for this PR and add in the PR description. Also, please read through the check list for your reference: https://github.com/atapas/react-play/wiki/ReactPlay-Code-Review-Checklist

This is the first time I am raising a PR to external Repo. I am not sure what you are talking about. could you please guide me here

Srinu126 avatar May 17 '22 13:05 Srinu126

@Srinu126 please create an issue for this PR and add in the PR description. Also, please read through the check list for your reference: https://github.com/atapas/react-play/wiki/ReactPlay-Code-Review-Checklist

This is the first time I am raising a PR to external Repo. I am not sure what you are talking about. could you please guide me here

No problem.

Give me a title and description of the work you are doing. I will do the rest(for the first time) and let you know so that you can do it from the next time.

atapas avatar May 17 '22 13:05 atapas

@Srinu126

Hi @Srinu126

I have added the issue: https://github.com/atapas/react-play/issues/190

Please check if all the details are added correctly.

atapas avatar May 18 '22 02:05 atapas

I have fixed the issues like keeping the api key in .env file, removed inline styling and also made SearchBar Component a functional component and also made the video preview available. everything is working fine and the only thing i need to work on is responsiveness and I will be working on it.

Srinu126 avatar May 18 '22 11:05 Srinu126

@Srinu126 Whatever comments are taken care, could you please mark them as resolved by clicking the Resolve Conversation button? That will help me to manage the pending comments better.

atapas avatar May 18 '22 13:05 atapas

@Srinu126 Please drop a "Review Ready" note when you want us to pick up for a review. Thanks!

atapas avatar May 21 '22 03:05 atapas

Hello @Srinu126

We will be moving the react-play project from the atapas account to an organization to help manage the project in a better way. The new organization URL is: https://github.com/reactplay.

The movement will take place between 12:30 - 14:00 hrs IST(7:00 am - 8:30 am GMT), 30th May 2022. Please refrain from pushing any changes between this time.

We will inform you when the movement is complete. You need to make a few minimal configuration changes after that. We will let you know.

atapas avatar May 30 '22 05:05 atapas

Hello @Srinu126

We will be moving the react-play project from the atapas account to an organization to help manage the project in a better way. The new organization URL is: https://github.com/reactplay.

The movement will take place between 12:30 - 14:00 hrs IST(7:00 am - 8:30 am GMT), 30th May 2022. Please refrain from pushing any changes between this time.

We will inform you when the movement is complete. You need to make a few minimal configuration changes after that. We will let you know.

The migration is complete. You can find the project here: https://github.com/reactplay

You no need to reclone the project. You just need to set the correct upstream. Here is the link: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-for-a-fork

atapas avatar May 30 '22 10:05 atapas

Hey @Srinu126

A reminder to get back on this play. This PR may be closed due to a lack of activities soon. Please let us know if you need any help.

Looking forward to getting the play in!

atapas avatar Aug 15 '22 09:08 atapas

Closing as NO RESPONE.

atapas avatar Oct 05 '22 02:10 atapas