react-play icon indicating copy to clipboard operation
react-play copied to clipboard

✨ [Feature request]: Add Testimonial Button

Open Shivam-Katare opened this issue 1 year ago • 9 comments

Is your feature request related to a problem? Please describe.

There should be an option to add a testimonial directly from here, instead of clicking on the View All button and then adding it. Having the option here along with View All would be more convenient.

image

Describe the solution you'd like.

There should be a button or link for submitting a testimonial directly on the same page where the testimonials are displayed. This button could be placed next to or below the "View All" button. Users would be able to add a testimonial without navigating to a separate page.

Describe alternatives you've considered.

On the same page, we can add a Modal for Testimonials. Instead of redirecting to a different page, a modal could pop up when users click "Add Testimonial." This would allow users to add their feedback without leaving the current page.

Screenshot / Screenshare

No response

Additional context

No response

Record

  • [X] I have checked the existing issues
  • [X] I have read the Contributing Guidelines
  • [ ] I want to work on this issue
  • [ ] I am a Hacktoberfest contributor

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Shivam-Katare avatar Oct 01 '24 11:10 Shivam-Katare

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

github-actions[bot] avatar Oct 01 '24 11:10 github-actions[bot]

Could you please assign this issue to me?

Adil-Khan-N avatar Oct 02 '24 03:10 Adil-Khan-N

Could you please assign this issue to me?

Unfortunately, you can only work one issue at a time,so other contributors can work.

priyankarpal avatar Oct 02 '24 05:10 priyankarpal

Can I work on this?

day-lee avatar Oct 02 '24 11:10 day-lee

Assigning to you @day-lee, Happy Coding!

Abhishek-90 avatar Oct 02 '24 11:10 Abhishek-90

This issue has not been resolved till now.Can I work on this issue?

KrishDave1 avatar Oct 10 '24 15:10 KrishDave1

@KrishDave1 Hi, I am currently working on it locally.

day-lee avatar Oct 10 '24 15:10 day-lee

Hey @day-lee ,

Any updates on the issue?

PriteshKiri avatar Oct 14 '24 08:10 PriteshKiri

Hi, @PriteshKiri

When I click on the +Testimonial button on https://reactplay.io/testimonials page, it doesn't show me the modal page, however, I can see it locally without problem. When I look at the network tab, I can see some token problem.

I think I can reuse the modal component and simply add a button to trigger it on the rending page. However, I wonder if it would work fine and show up on the page when deployed or not. Can I have your opinion please? Thanks,

image

day-lee avatar Oct 14 '24 13:10 day-lee

This issue has not been resolved till now.Can I work on this issue?

nilaygit-10721 avatar Nov 05 '24 12:11 nilaygit-10721

@Shivam-Katare @Sachin-chaurasiya can you please check the suggestion by @day-lee ?

PriteshKiri avatar Nov 06 '24 05:11 PriteshKiri

@nilaygit-10721 the issue is under discussion. Can you please checkout other issues?

PriteshKiri avatar Nov 06 '24 05:11 PriteshKiri

Hi, @PriteshKiri

When I click on the +Testimonial button on https://reactplay.io/testimonials page, it doesn't show me the modal page, however, I can see it locally without problem. When I look at the network tab, I can see some token problem.

I think I can reuse the modal component and simply add a button to trigger it on the rending page. However, I wonder if it would work fine and show up on the page when deployed or not. Can I have your opinion please? Thanks,

image

Hey @day-lee, in order to add a testimonial, users need to authenticate via GitHub. When they click the +Testimonial button, we retrieve the user token from Nhost and then display the add testimonial page. However, I noticed that the URL https://auth.nhost.run/v1/token is failing, which is why the add testimonial page isn't rendering properly. cc: @priyankarpal can you check why https://auth.nhost.run/v1/token is failing on production?

Sachin-chaurasiya avatar Nov 06 '24 06:11 Sachin-chaurasiya

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Dec 06 '24 12:12 github-actions[bot]