event-loop icon indicating copy to clipboard operation
event-loop copied to clipboard

Test on PHP 8.2

Open WyriHaximus opened this issue 3 years ago • 1 comments

With PHP 8.2 coming out later this year, we should be reading for it's release to ensure all out code works on it.

WyriHaximus avatar Aug 13 '22 13:08 WyriHaximus

In order to finish this PR https://github.com/phpspec/prophecy/issues/556 needs to be resolved. Or we need to consider one of the solutions in the issue. I'll file this PR onto our other packages as well, including the TEMP commit with a temporary workaround so I can continue looking for potential issues on 8.2.

WyriHaximus avatar Aug 13 '22 21:08 WyriHaximus

@WyriHaximus wanted to ask what the current status of this PR is. I remember seeing some deprecation notices last time I checked, but I can't see them anymore. Maybe it fixed itself in the meantime :D

SimonFrings avatar Jan 03 '23 12:01 SimonFrings

@SimonFrings Good question, will force push to find out

WyriHaximus avatar Jan 03 '23 12:01 WyriHaximus

@SimonFrings All green now :tada:

WyriHaximus avatar Jan 03 '23 18:01 WyriHaximus

@WyriHaximus Nice, just noticed the warnings for ext-event with PHP 8+. Nothing you caused with this PR, this is why I'd say we merge this as is and look into these warnings in a follow up PR.

We should also keep in mind that ubuntu-18.04 will cause failing tests the next couple of months, so we should also look into a solution for this as well.

SimonFrings avatar Jan 04 '23 12:01 SimonFrings

@SimonFrings Sounds like a plan, thought we already updated all ubuntu runners, to be honest.

WyriHaximus avatar Jan 04 '23 16:01 WyriHaximus