dns icon indicating copy to clipboard operation
dns copied to clipboard

Published 20 hours ago • verified publisher icon reactphp

support for search options in /etc/resolv.conf

Open Chrisdowson opened this issue 3 years ago • 6 comments

Chrisdowson avatar May 21 '22 13:05 Chrisdowson

Thank you for filing this PR, could you include unit tests, and look into fixing the failing unit tests?

WyriHaximus avatar May 21 '22 15:05 WyriHaximus

Thank you for filing this PR, could you include unit tests, and look into fixing the failing unit tests?

so I have fixed unit tests, when will u accept?

Chrisdowson avatar Nov 11 '22 15:11 Chrisdowson

Hey @Chrisdowson, thanks for updating the PR :+1:

Unfortunately the test are currently failing, could look into that. The reactphp/dns project has over 20 million installations and we ourselves use it in nearly every ReactPHP project. This is why we have to assure that everything works flawlessly to avoid breaking current installations.

SimonFrings avatar Nov 14 '22 10:11 SimonFrings

@SimonFrings ,Hi, I have fixed bugs, And the test are success,When will you accept it?

Chrisdowson avatar Dec 24 '22 13:12 Chrisdowson

em, long time now,When will this PR be merged.And what should I do?

Chrisdowson avatar Dec 07 '23 08:12 Chrisdowson

Hey @Chrisdowson, I just had a chat with @SimonFrings about your pull request, and he mentioned that there are still some suggested changes remaining after his initial review. Once those changes are made, your pull request will go through another round of review. Additionally we don't have to change google in our tests as this has already been done in https://github.com/reactphp/event-loop/pull/263/files.

I hope this answer keeps you in the loop and we can move forward. 👍

yadaiio avatar Feb 28 '24 16:02 yadaiio