rapps-db
rapps-db copied to clipboard
reactos
[RAPPS-DB] Fix PNG icons for renpy.ico, sublime_text.ico, and winrar.ico
This is a fix of PR#211 and commit d2a7485
Three icons were included with this commit which were renpy.ico, sublime_text.ico and winrar.ico. These were not actual ICO files, but actually PNG files that had had their extensions changed to ICO.
This commit replaces these bad icon files with the correct ICO files with their appropriate icon headers. These will not display correctly in ReactOS, but there is work in progress to display these soon.
These will not display correctly in ReactOS, but there is work in progress to display these soon.
So they do still have png data inside?
Thanks @Doug-Lyons, after this PR is merged we can also merge the updated validator, so that this does not happen again: #234
These will not display correctly in ReactOS, but there is work in progress to display these soon.
So they do still have png data inside?
Yes. They will make good test examples to verify our PNG changes work after they are merged later. In the meantime, they should trigger my debug messages telling us that they have PNG's embedded. They are not helpful as they are now. They are not displayable by any OS or ReactOS.
Even if Windows is able to use bitmaps as icons, it shouldn't move us away from keeping quality standards.
Quality standards would mean that we try to achieve what Windows can achieve. This PR does neither fix the icon displaying, nor does it help ReactOS to evolve. The only thing it does is wasting our time on the noise in the rapps DB. By making it even larger. This PR does not have any immediate gain. It just makes it easier and even more tempting for us to accumulate even more workarounds in the future. Workarounds are no quality standard. Why not (ab)using the current 3 "renamed-png-icons" as an easy-to-reach testcase instead?