reactor-netty icon indicating copy to clipboard operation
reactor-netty copied to clipboard

Review calls to channel.write vs channelContextHandler.write

Open smaldini opened this issue 7 years ago • 1 comments

Channel.write adds an extra stack line and might evolve in Netty 5 to be fully dispatched to eventLoop. ChannelContextHandler will be safe when called from a netty event loop. Part of the investigation will be to evaluate if ChannelOperationHandler need to use eventLoop directly or append a publishOn(Scheduler.from(eventLoop)) to every written Publisher.

smaldini avatar Apr 21 '18 05:04 smaldini

Check channel.write vs channelContextHandler.write http://normanmaurer.me/presentations/2014-facebook-eng-netty/slides.html#29.0

ChannelOperationHandler is not involved in the outbound operations anymore.

violetagg avatar May 11 '20 09:05 violetagg

I checked this and channel.write vs channelContextHandler.write is OK

violetagg avatar Oct 21 '22 13:10 violetagg