reactor-netty icon indicating copy to clipboard operation
reactor-netty copied to clipboard

ensures flux receiver terminates subscriber on dispose

Open OlegDokuka opened this issue 3 years ago • 4 comments

this fix addresses https://github.com/rsocket/rsocket-java/issues/1050

OlegDokuka avatar Aug 19 '22 12:08 OlegDokuka

@OlegDokuka There is a test failure. Can you take a look? Can you provide a test that shows the issue?

violetagg avatar Aug 19 '22 15:08 violetagg

There is a test failure. Can you take a look?

@violetagg fixed

OlegDokuka avatar Aug 19 '22 15:08 OlegDokuka

@violetagg added a test that reflects the problem. It fails on the 1.0.x branch now

OlegDokuka avatar Aug 19 '22 15:08 OlegDokuka

@violetagg it seems that the other tcp-http related test fails because of the fix and I'm not sure how to clearly fix it...

OlegDokuka avatar Aug 19 '22 18:08 OlegDokuka

@OlegDokuka I rebased the changes and fixed the failing test. Once the CI is green we can merge this.

violetagg avatar Oct 20 '22 07:10 violetagg