reactor-kafka
reactor-kafka copied to clipboard
reactor
Add Micrometer Support for Consumer and Producer
Resolves https://github.com/reactor/reactor-kafka/issues/206#issuecomment-1006119883
Need to rework this on Monday due to gradle upgrade (thanks @simonbasle ).
Another thought would be to just add the listener interface and leave off the micrometer implementations out and just add the code to the reference manual since it's so small; the user can copy/paste.
WDYT?
Another thought would be to just add the listener interface and leave off the micrometer implementations out and just add the code to the reference manual since it's so small; the user can copy/paste.
WDYT?
I think it misses the whole point. As a user, I'd like to just have an easy way of making this work. If you expect most of the users to copy-paste the metrics, I think it worth it to let them be there, and the more advanced needs will implement the interface.
@garyrussell yeah that could be an intermediate way to improve things in 1.3.x.
Let me list a few factoids and constraints:
- Micrometer 2.x is around the corner, GA late 2022
- there are no metrics at all in reactor-kafka 1.3.x right now
- reactor-kafka 1.3.x cannot use Micrometer 2.x (we need to maintain compatibility with reactor-core 3.4.x which uses Micrometer 1)
- there could be a reactor-kafka 1.4.0, part of the 2022.0 upcoming release cycle (or compatible with it) that uses Micrometer 2.x (late 2022)
@migroskub I understand your perspective, but as stated above there are no metrics right now. if you're adamant about metrics right now then you could be considered an advanced user and would get an interface to listen and implement metrics with some effort, albeit minimal. Then in 1.4.0 all users will get something more future-proof working off the shelf.
Just playing devil's advocate here. I don't want to rush implementing metrics with Micrometer 1.x when Micrometer 2.x is around the corner.
Replaced by https://github.com/reactor/reactor-kafka/pull/323 available in 1.3.17