reactor-core icon indicating copy to clipboard operation
reactor-core copied to clipboard

Hidden TOC appears with long header titles

Open dev-jonghoonpark opened this issue 10 months ago • 5 comments

The Table of Contents (TOC), which is hidden under the LEFT PANEL, appears when the header has a long title.

You can check in https://projectreactor.io/docs/core/release/reference/metrics.html

Image

When the screen width is less than 1024px, the LEFT PANEL disappears, making the TOC more visible.

Image

If the screen width is less than or equal to 800px, the TOC disappears completely, and there is no issue in this case.


Why is the hidden TOC necessary?

dev-jonghoonpark avatar Mar 07 '25 15:03 dev-jonghoonpark

Hey, thank you for a detailed report! I don't think it's necessary, it must be a bug. Do you have an idea where the issue lies? If so, a contribution would be very much welcome.

cc @violetagg - I believe the reactor-netty antora docs have the same issue.

chemicL avatar Mar 10 '25 13:03 chemicL

I realized that in Antora, there are two TOCs: one inside the content and one outside.

this is one inside (for mobile) Image

this is one outside (for desktop) Image

In Antora documentation, the TOC inside the content is completely hidden using display: none for desktop size. On the other hand, in the reactor documentation, the TOC inside the content is hidden inside the left panel using position: absolute.

How about simply hiding the TOC inside the content with display: none in the reactor documentation as well?

It seems that to achieve this, a PR would need to be submitted to https://github.com/reactor/antora-ui-projectreactor.

dev-jonghoonpark avatar Mar 10 '25 14:03 dev-jonghoonpark

At some point we fixed that https://github.com/reactor/reactor-netty/pull/3177 Let me check again Reactor Netty documentation

violetagg avatar Mar 10 '25 15:03 violetagg

@chemicL @dev-jonghoonpark mmm yeah ignore my previous comment, it seems the PR that I mentioned fixes another thing, but the issue described here is present with Reactor Netty documentation also

violetagg avatar Mar 10 '25 15:03 violetagg

Image

Additionally, I discovered that the button on the top right exists but serves no functional purpose.

While resolving this issue, it would be good to hide this button as well.

dev-jonghoonpark avatar Mar 11 '25 08:03 dev-jonghoonpark