reactor-core
reactor-core copied to clipboard
reactor
Establishing approach
hi @chemicL and @OlegDokuka - kicked off some work for https://github.com/reactor/reactor-core/issues/3545 but wanted to verify the approach before i go any further.
So my plan is as follows.
- Work out a base approach to get the simple repeat test pass
- Add necessary functionality for the rest of the tests to pass
- Refactor and pull the common bits between repeat/retry as previously suggested
- See if anything else is missing in the repeat functionality and add it
@Desislav-Petrov Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
@Desislav-Petrov Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Hey, @Desislav-Petrov. I'm trying to go through some PRs that were not given enough attention. Please accept the team's apologies. I had a brief look and would like to know whether after not gaining much attention from us you are still willing to make progress on this.
My first concern is a public API change - we need to make sure that anything that we add does not remove existing functionality.
Also, the next(-1) signal looks suspicious - in case of differences between the implementation in reactor-extras, can you list them with a high-level explanation?
Let me know, thanks.
Hey @chemicL - I'm still keen on working on that as long as I get some support/gudaince - let me take a look since it's been a while to summarise the idea.
@Desislav-Petrov take your time. I'll try to be helpful. Should I be occupied to the limits with other concerns, I'll be sure to let you know.