reactor-core icon indicating copy to clipboard operation
reactor-core copied to clipboard

Repeat specification for use with repeatWhen operator

Open chemicL opened this issue 2 years ago • 11 comments

Similarly to the way Retry is implemented with accompanying retryWhen(RetrySpec) operator, the Repeat functionality from reactor-addons project should be implemented in reactor-core and phased out from reactor-extras (module of reactor-addons). It can potentially reuse the primitives that already exist for the retry functionality.

chemicL avatar Jul 26 '23 11:07 chemicL

Hi @chemicL - i'm keen to explore this one - could you please assign to me? Thanks

Desislav-Petrov avatar Jul 30 '23 19:07 Desislav-Petrov

hi @chemicL - i was looking at how the retry has been ported from addons to the core as an inspiration for the repeat. Looks like the port hasn't been exactly 1;1 in terms of functionality so I assume that will be the case for repeat as well. Do we need to preserve all the functionality that's currently offered by the addons repeat? Any guidance will be appreciated.

Desislav-Petrov avatar Aug 09 '23 20:08 Desislav-Petrov

@OlegDokuka can you please respond when you find a moment? (I'm going to be away for a few days)

chemicL avatar Aug 10 '23 13:08 chemicL

@Desislav-Petrov we don't literally have to port impl from reactor-addons but rather create a shared common for both retry and repeat operators. That means the logic implemented in Retry builder can go into something like "CommonRecurring" (or whatever name we endup) and then implement Repeat builder having that base mechanism as well as Retry.

OlegDokuka avatar Aug 17 '23 11:08 OlegDokuka

Got you - thanks, will have a go

Desislav-Petrov avatar Sep 18 '23 21:09 Desislav-Petrov