reactor-addons icon indicating copy to clipboard operation
reactor-addons copied to clipboard

Published 20 hours ago • verified publisher icon reactor

RxJava 3.1.x support

Open linux-china opened this issue 2 years ago • 5 comments

From RxJava 3.1.1 https://github.com/ReactiveX/RxJava/releases/tag/v3.1.1

The operator fusion-related interfaces and two atomic queue implementations have been promoted to standard, thus officially supported in the io.reactivex.rxjava3.operators package. https://github.com/ReactiveX/RxJava/issues/7320

The package for following classes changed:

  • QueueFuseable
  • QueueDisposable
  • QueueSubscription
  • ScalarSupplier
  • SimpleQueue
  • SimplePlainQueue
  • SpscArrayQueue
  • SpscLinkedArrayQueue

And RxJava3Adapter can not work with RxJava 3.1.x version.

linux-china avatar Mar 31 '22 17:03 linux-china

Can you pinpoint what is breaking exactly? IIRC the RxJava3 adapater doesn't use any of these classes explicitly. I'm also wondering about the need to support RxJava 3.0.x?

simonbasle avatar Apr 12 '22 07:04 simonbasle

From https://github.com/reactor/reactor-addons/blob/main/reactor-adapter/src/main/java/reactor/adapter/rxjava/RxJava3Adapter.java

The following classes are not available from RxJava 3.1.1

import io.reactivex.rxjava3.internal.operators.completable.CompletableFromPublisher;
import io.reactivex.rxjava3.internal.operators.single.SingleFromPublisher;
import io.reactivex.rxjava3.internal.subscriptions.SubscriptionHelper;

linux-china avatar Apr 12 '22 16:04 linux-china

indeed, got it. so what's the play here? we have to break support for RxJava 3.0.x and 3.1.0 in a patch release :/ any idea how the user base sizes compare between RxJava 3.0 and 3.1.1 ?

simonbasle avatar Apr 12 '22 17:04 simonbasle

I have no idea about this :) Now in my project, and I just inlined 4 interfaces in my jar:

image

I think it's ok to upgrade RxJava 3.1.x and document this change.

linux-china avatar Apr 12 '22 20:04 linux-china

latest micronaut uses 3.1.5, I think it's better to upgrade. RxJava3.0 user could still use the old version

semistone avatar Sep 06 '22 01:09 semistone

Do you have any update on supporting rxjava 3.1+?

guillaumelamirand avatar Oct 19 '22 12:10 guillaumelamirand

Hello ! This problem is critical for us, and avoids the use of rxJava 3.1. In RxJava 3.1 release note , it's specified that the 3.0.x patch line won't be developed further. Any progression of having a reactor-addons compatible with rxJava 3.1 ?

marcambier avatar Oct 19 '22 12:10 marcambier

@linux-china @marcambier and others, would you like to make a contribution?

OlegDokuka avatar Oct 20 '22 07:10 OlegDokuka