BlockHound icon indicating copy to clipboard operation
BlockHound copied to clipboard

Published 20 hours ago • verified publisher icon reactor

Add Premain-Class attribute

Open nickcaballero opened this issue 2 years ago • 2 comments

This PR adds premain method and manifest attribute, supporting the installation of the agent via -javaagent= JVM option.

nickcaballero avatar Sep 14 '22 04:09 nickcaballero

@nickcaballero Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Sep 14 '22 04:09 pivotal-cla

@nickcaballero Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Sep 14 '22 04:09 pivotal-cla

I just rebased this PR on top of latest master.

pderop avatar Jan 17 '23 10:01 pderop

@pderop I've updated the PR with your suggestions! Went with the loadIntegrations approach for the builder, which I think is a lot cleaner.

nickcaballero avatar Jan 17 '23 16:01 nickcaballero

@nickcaballero ,

thanks a lot for updating the PR :smiley:,

One last small thing, could you just add a note somewhere in the documentation, please check https://github.com/reactor/BlockHound/pull/297#pullrequestreview-1247718113 ?

thanks

pderop avatar Jan 17 '23 16:01 pderop

@nickcaballero, thanks for this PR ! @chemicL, thanks for the review !

I'll change the parameter names of the premain method in another PR, let's merge this one for the moment.

pderop avatar Jan 20 '23 15:01 pderop