vi.react.dev icon indicating copy to clipboard operation
vi.react.dev copied to clipboard

Published 20 hours ago • verified publisher icon reactjs

Review process

Open ltmylinh opened this issue 6 years ago • 4 comments

This issue is created to discuss about review process:

  • How many approvals do we need for a PR?
  • Who will take responsibility to merge PR?

ltmylinh avatar Feb 09 '19 01:02 ltmylinh

  • To make the review process solid, I think we should have at least 1 approval.

  • At this time, we are only 2 maintainers, I think both of us can merge if a PR is approved.

nampdn avatar Feb 09 '19 03:02 nampdn

I prefer at least 2 approvals. More reviewers will have good quality. We have @anhphamduy in our team, right?

ltmylinh avatar Feb 09 '19 12:02 ltmylinh

@nampdn @ltmylinh Hi bros, Can I join this project? I will help translate at night.

Quynh-Nguyen avatar Feb 28 '19 01:02 Quynh-Nguyen

Yo yo, I want to help as well.

huyqdang avatar Mar 20 '19 16:03 huyqdang