vi.react.dev icon indicating copy to clipboard operation
vi.react.dev copied to clipboard

Translation: Responding to Events

Open phuc1nguyen opened this issue 1 year ago • 3 comments

  • [x] Overview
  • [x] Adding event handlers
  • [x] Event propagation
  • [x] Can event handlers have side effects?
  • [x] Recap

phuc1nguyen avatar May 02 '23 07:05 phuc1nguyen

Hi maintainers, since this is not a short page and it's my first translation, could I get a quick review to see whether I'm heading in the right direction?

Like, I'm using both prop and props, is it ok or it should be prop and các/những prop since we keep props untranslated?

Thanks in advance!

phuc1nguyen avatar May 02 '23 07:05 phuc1nguyen

Hi maintainers, since this is not a short page and it's my first translation, could I get a quick review to see whether I'm heading in the right direction?

Like, I'm using both prop and props, is it ok or it should be prop and các/những prop since we keep props untranslated?

Thanks in advance!

IMO, we can keep prop and các/những prop. Thanks :)

ltmylinh avatar May 09 '23 04:05 ltmylinh

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.1 KB (🟢 -45 B) 169.73 KB
/500 76.09 KB (🟢 -45 B) 169.72 KB
/[[...markdownPath]] 77.52 KB (🟢 -45 B) 171.15 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] avatar May 22 '23 03:05 github-actions[bot]