rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

New RFC: Mechanism to substitute the react build.

Open Gaelan opened this issue 5 years ago • 6 comments

This is fairly borderline in terms of whether it needs to be an RFC—if this is better suited for the primary react repo, I'm happy to move it over there.

Gaelan avatar Feb 12 '20 06:02 Gaelan

Hi @Gaelan!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Feb 12 '20 06:02 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Feb 12 '20 07:02 facebook-github-bot

I think maybe @sophiebits suggested something similar at some point.

gaearon avatar Feb 12 '20 13:02 gaearon

Yes. Still think it’s a good idea.

sophiebits avatar Feb 12 '20 17:02 sophiebits

Tbh this seems more oriented towards GH repo with a proof of concept.

gaearon avatar Aug 18 '21 22:08 gaearon

I think the really annoying part here is that the versions need to match, and that's a bit tricky. I guess DevTools could try to download a matching version from npm. Then there's a question of: do we also replace react (or react-dom only), what about scheduler, what to do when they get optimized/inlined by the bundler, and so on. I think an RFC for this would need to go into a lot more detail about how the hard parts are solved.

gaearon avatar Aug 18 '21 22:08 gaearon