fix: replace hardcoded sidebar width (342px) with responsive Tailwind…
Summary
Replaced the hardcoded sidebar width (lg:w-[342px]) with Tailwind’s responsive utility (lg:w-80).
This prevents overflow issues in Firefox and ensures better cross-browser consistency.
Related Issue
Fixes #7976
Changes
- Updated
SidebarNav.tsxandTopNav.tsxto remove arbitrarylg:w-[342px] - Replaced with
lg:w-80(closest Tailwind equivalent) for responsive and accessible layout
Before/After
- Before (Firefox): Sidebar overflowed onto main content
- After: Sidebar aligns correctly and no longer overlaps
Hi @DeveloperViraj!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Size changes
📦 Next.js Bundle Analysis for react-dev
This analysis was generated by the Next.js Bundle Analysis action. 🤖
🎉 Global Bundle Size Decreased
| Page | Size (compressed) |
|---|---|
global |
110.53 KB (-8 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Five Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/404 |
128.09 KB (-4 B) |
238.62 KB |
/500 |
128.09 KB (-4 B) |
238.63 KB |
/[[...markdownPath]] |
130.52 KB (-4 B) |
241.05 KB |
/errors |
128.34 KB (-4 B) |
238.87 KB |
/errors/[errorCode] |
128.31 KB (-4 B) |
238.85 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Hi maintainers 👋,
This PR fixes issue #7976 (sidebar overflow in Firefox) by replacing the hardcoded width with a responsive Tailwind class.
All checks have passed ✅ and CLA is signed.
Kindly review when possible 🙏. Thanks for maintaining this awesome project! 🚀