react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

fix(scroll): #5995 keep computed height to avoid page jump

Open ssan93 opened this issue 1 year ago • 3 comments

Closes #5995

Issue When the iframe gets out of range, it unmounts to save memory. While scrolling on desktop widths (vertical layout), the iframes are unmounting and their height gets reduced. This causes page jump as the previous content gets shorter.

Solution By keeping the calculated height value of the iframe, we can set the height of the iframe wrapper to prevent shrinking and remove the page jumps.

https://github.com/user-attachments/assets/eccc0485-b989-443c-8aad-9c125f377cbf

Untitled

ssan93 avatar Sep 07 '24 04:09 ssan93

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 4:20am
react-dev ✅ Ready (Inspect) Visit Preview Sep 7, 2024 4:20am

vercel[bot] avatar Sep 07 '24 04:09 vercel[bot]

Hi @ssan93!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Sep 07 '24 04:09 facebook-github-bot

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.19 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

github-actions[bot] avatar Sep 07 '24 04:09 github-actions[bot]