react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Clarify that `false` still affects the render tree by occupying a position

Open enterprisey opened this issue 1 year ago • 2 comments

From https://stackoverflow.com/questions/70253988/react-resetting-and-preserving-state and https://stackoverflow.com/questions/77718975/why-would-two-react-components-seemingly-in-the-same-position-get-different-stat, it seems that the "Resetting state at the same position" section has confused a few people, including myself. I have clarified the text to hopefully reduce the chance of this confusion, which centers around whether the false created by the evaluation of the && expression influences the calculated positions in the render tree.

enterprisey avatar Dec 26 '23 20:12 enterprisey

Hi @enterprisey!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 26 '23 20:12 facebook-github-bot

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 77.36 KB (🟢 -17 B) 181.18 KB
/500 77.36 KB (🟢 -17 B) 181.17 KB
/[[...markdownPath]] 78.95 KB (🟢 -17 B) 182.77 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] avatar Dec 26 '23 20:12 github-actions[bot]