react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

[GH workflow] update `analyze.yml` to avoid noisy notification

Open awxiaoxian2020 opened this issue 2 years ago • 8 comments

When I merge PR into main branch, I always received the notification that the workflow failed like this.

I found the PR workflow is different from main branch. The latter doesn't generate comment indeed but it upload it and should be used the other workflow I metion at start.

The PR workflow:

pr

The main workflow:

main

awxiaoxian2020 avatar Mar 23 '23 03:03 awxiaoxian2020

https://github.com/reactjs/react.dev/blob/b9af9f57232fd6c47f90cf39eef0fc12fa8743f6/.github/workflows/analyze_comment.yml#L13 It seems not including push and we shouldn't but how we handle with this noisy notification?

awxiaoxian2020 avatar Mar 23 '23 04:03 awxiaoxian2020

If you have a fix in mind, please send it!

gaearon avatar Mar 23 '23 15:03 gaearon

@gaearon The point is that do we need analyze comment on main branch?

awxiaoxian2020 avatar Mar 24 '23 06:03 awxiaoxian2020

Yea it is better to have. Because sometimes commits land directly into main rather than PR.

harish-sethuraman avatar Mar 24 '23 06:03 harish-sethuraman

Yea it is better to have. Because sometimes commits land directly into main rather than PR.

We can add conditions, I think. I will look into it on the weekend.

awxiaoxian2020 avatar Mar 24 '23 06:03 awxiaoxian2020

@awxiaoxian2020 do you find this job useful when I works? I was thinking we just remove it.

rickhanlonii avatar Sep 02 '25 17:09 rickhanlonii

@rickhanlonii please check out #7667 — there are just a few small one-line fixes

alinkedd avatar Sep 02 '25 20:09 alinkedd

@awxiaoxian2020 do you find this job useful when I works? I was thinking we just remove it.

Yes, you can remove it.

awxiaoxian2020 avatar Sep 24 '25 01:09 awxiaoxian2020