react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Published 20 hours ago • verified publisher icon reactjs

chore: Add content for visual component testing

Open mike-plummer opened this issue 1 year ago • 3 comments

Testing section currently provides information on how to test components by fully-mocking the render surface (JSDOM) - adding content around new options for visual component testing provided by Cypress which recently went GA. Trying to structure as a compromise solution between fast JSDOM-based component tests and slower, complex E2E tests.

Appreciate any feedback or suggestions, thanks in advance for reviewing!

mike-plummer avatar Jan 19 '23 17:01 mike-plummer

Hi @mike-plummer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jan 19 '23 17:01 facebook-github-bot

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

github-actions[bot] avatar Jan 19 '23 17:01 github-actions[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jan 19 '23 19:01 facebook-github-bot

I see the new site has gone live (nice work, btw! 💯 ) and this content no longer has a home. I'm not seeing a section for Testing - was this a deliberate omission, or did it just not make the initial cutover? If you feel a Testing section would be worthwhile I'd be happy to take a stab at scaffolding one out, or I can close this out if you don't envision that sort of info living here

mike-plummer avatar Mar 27 '23 19:03 mike-plummer