react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Adding Script component for inline script :)

Open sanjaiyan-dev opened this issue 2 years ago • 5 comments

Using <Script /> component from next/script for inline colour mode script.

sanjaiyan-dev avatar Aug 01 '22 12:08 sanjaiyan-dev

Using <Script /> component from next/script for inline colour mode script.

Can you elaborate what behavior you're seeing without this change, what behavior the change results in, and why we should change it?

eps1lon avatar Aug 01 '22 15:08 eps1lon

Using <Script /> component from next/script for inline colour mode script.

Can you elaborate what behavior you're seeing without this change, what behavior the change results in, and why we should change it?

This doesn't have significant improvement but which have future benefits (In future next js versions)

Sorry if I made any mistakes 🙌😊

sanjaiyan-dev avatar Aug 01 '22 15:08 sanjaiyan-dev

Sorry if I made any mistakes raised_handsblush

I didn't mean to imply that. I was wondering what this change is doing in the first place or what it's intended to do.

eps1lon avatar Aug 01 '22 15:08 eps1lon

Sorry if I made any mistakes raised_handsblush

I didn't mean to imply that. I was wondering what this change is doing in the first place or what it's intended to do.

Actually I thought adding Script component might have behind the scene optimizations and better streaming support 🙌

sanjaiyan-dev avatar Aug 01 '22 15:08 sanjaiyan-dev

Sorry if I made any mistakes raised_handsblush

I didn't mean to imply that. I was wondering what this change is doing in the first place or what it's intended to do.

And i thought it is a best practise to use next/script :)

sanjaiyan-dev avatar Aug 04 '22 15:08 sanjaiyan-dev