react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Lazy loading deferred components to improve the load time 🚀⌚🚀

Open sanjaiyan-dev opened this issue 2 years ago • 6 comments

Dynamically importing deferred components.

Extremely sorry if I made any mistakes

sanjaiyan-dev avatar Jul 08 '22 11:07 sanjaiyan-dev

Hi @sanjaiyan-dev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jul 08 '22 11:07 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jul 08 '22 12:07 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jul 08 '22 12:07 facebook-github-bot

how did you verify that something's actually improved? can you share your methodology?

gaearon avatar Jul 08 '22 19:07 gaearon

@gaearon Sorry sir, actually I thought dynamically loading the component should improve load speed hence that particular component is conditionally loaded (according to screen size)

I am sorry if I am wrong :(

sanjaiyan-dev avatar Jul 08 '22 20:07 sanjaiyan-dev

how did you verify that something's actually improved? can you share your methodology?

@gaearon , I thought loading of <MobileNav /> component is conditional according to screen size so by making it dynamic we can reduce the amount of file size for large screen devices. (@gaearon )

I am extremely sorry if I am wrong :(

sanjaiyan-dev avatar Jul 29 '22 19:07 sanjaiyan-dev